-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polish(v2): improve Docusaurus 1 to 2 migration developer experience #2884
polish(v2): improve Docusaurus 1 to 2 migration developer experience #2884
Conversation
… avoid parsing errors, if using special characters
Deploy preview for docusaurus-2 ready! Built with commit 8331763 |
This is my bad. It initially had a fallback, but I removed it to make it explicit. I think I was thinking if we could have |
I'm not agaist making it explicit actually, as long as we have an error saying the position is missing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Let's use the commit message format for easier PR triaging when releasing. I think this would be under "tag: polish" :D
@yangshun FYI we don’t have a commit type as "polish", instead we need to use a "refactor". |
But we have a tag for it. Can we add the polish commit type? |
Perhaps it's better (more usual) to replace polish with refactor. https://github.com/facebook/docusaurus/blob/master/lerna.json#L11 |
Although I still don't see the big trouble here, the types of commits and lerna labels do not have to match. This is a bit confusing, but we don't have many labels 🤷♂️ |
I recently migrated TS cheatsheets from v1 to v2.
Here are migration doc additions, and improved error messages, that would have helped me save some time.