feat(v2): add nojekyll file to static folder for all templates #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 2e99722 |
lex111
reviewed
Jun 7, 2020
There was a problem hiding this comment.
I think it would be nice to actualize the green block quote on this page.
https://v2.docusaurus.io/docs/deployment/#docusaurusconfigjs-settings
@lex111 what does this mean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a
.nojekyllfile to thestaticdirectory for all templates found inpackages/docusaurus-init/templates.This automatically disables Jekyll when publishing on GitHub Pages. This PR closes #2892.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
For each template:
cdinto the template and runyarn build.nojekyllfileRelated PRs
Might need to update https://v2.docusaurus.io/docs/next/static-assets/#caveats