Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): adjust anchor offset when routes switched #2909

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 9, 2020

Motivation

Resolve #2907

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Disable hideOnScroll in the config file (if enabled)
  2. Build a site
  3. Go to direct link to anchor
  4. Click on a link that leads to anchor on another page (or simulate this behavior via this snippet (document.getElementById('features')).scrollIntoView())

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Jun 9, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 9, 2020
@lex111 lex111 requested a review from yangshun June 9, 2020 06:35
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit b2d53b6

https://deploy-preview-2909--docusaurus-2.netlify.app

@yangshun yangshun merged commit 5b9f4dd into master Jun 16, 2020
@yangshun yangshun deleted the lex111/iss2907 branch June 18, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor links go to a scroll position that is slightly lower
4 participants