Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): upgrade react-loadable-ssr-addon #2921

Merged
merged 5 commits into from
Jun 16, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 11, 2020

Fix for #2898

Using the newly published react-loadable-ssr-addon release, after my fix got merged: themgoncalves/react-loadable-ssr-addon#21

@slorber slorber requested a review from yangshun as a code owner June 11, 2020 13:04
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 11, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 9dcbc1e

https://deploy-preview-2921--docusaurus-2.netlify.app

@slorber slorber requested a review from lex111 June 11, 2020 14:47
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing bugs in the packages we rely on :)

@yangshun yangshun merged commit c1102a4 into facebook:master Jun 16, 2020
@yangshun yangshun changed the title bug(v2): upgrade react-loadable-ssr-addon fix(v2): upgrade react-loadable-ssr-addon Jun 16, 2020
@yangshun yangshun added the pr: bug fix This PR fixes a bug in a past release. label Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants