Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): remove unused hooks from bootstrap theme #2931

Merged
merged 2 commits into from
Jun 14, 2020

Conversation

fanny
Copy link
Contributor

@fanny fanny commented Jun 14, 2020

Motivation

Remove hooks related to dark theme

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
N\A

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@fanny fanny requested a review from yangshun as a code owner June 14, 2020 11:42
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 14, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 14, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 275bf57

https://deploy-preview-2931--docusaurus-2.netlify.app

@yangshun yangshun merged commit 22178eb into master Jun 14, 2020
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jun 17, 2020
@yangshun yangshun deleted the fanny/remove-unused-hooks branch June 18, 2020 13:27
@anshulrgoyal
Copy link
Contributor

@fanny can u provide some docs for the bootstrap theme. We are writing validation for all official plugin and themes. But I am unable to find docs for it. Here is the #2970

@fanny
Copy link
Contributor Author

fanny commented Jun 22, 2020

Opss.. I deleted the PR that made this, I'll upload again.

@anshulrgoyal
Copy link
Contributor

@fanny I talking more about themeConfig.

@fanny
Copy link
Contributor Author

fanny commented Jun 22, 2020

It's here #2981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants