Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): Declare @docusaurus-plugin-debug as dependency of preset classic #2944

Merged
merged 1 commit into from
Jun 16, 2020
Merged

fix(v2): Declare @docusaurus-plugin-debug as dependency of preset classic #2944

merged 1 commit into from
Jun 16, 2020

Conversation

SamChou19815
Copy link
Contributor

Motivation

Missed it in #2929. We should probably include docusaurus start in E2E test in the future to prevent this kind of bug.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Nothing breaks in CI

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@SamChou19815 SamChou19815 requested a review from yangshun as a code owner June 16, 2020 14:06
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit d9535ba

https://deploy-preview-2944--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 16, 2020
@yangshun yangshun merged commit 85ad312 into facebook:master Jun 16, 2020
@yangshun yangshun added the pr: bug fix This PR fixes a bug in a past release. label Jun 16, 2020
@SamChou19815 SamChou19815 deleted the debug-as-preset-classic-dep branch June 19, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants