feat(v2): configureWebpack merge strategy + use file-loader for common asset types #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add webpack merge strategy feature to enable plugins to prepend some webpack configuration (like the ideal image plugin that should override the default image loader)
|
Deploy preview for docusaurus-2 ready! Built with commit c7d1154 |
jbaileyashe
reviewed
Jun 25, 2020
| @@ -932,3 +932,96 @@ class HelloWorld { | |||
| You may want to implement your own `<MultiLanguageCode />` abstraction if you find the above approach too verbose. We might just implement one in future for convenience. | |||
|
|
|||
| If you have multiple of these multi-language code tabs, and you want to sync the selection across the tab instances, refer to the [Syncing tab choices section](#syncing-tab-choices). | |||
|
|
|||
There was a problem hiding this comment.
Great documentation! This will be really nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The file loaders are useful to be able to require pdfs and images and videos from markdown files, which permits to colocate assets next to the markdown files (more convenient than the static folder)
The merge strategy is useful for having full control to append/prepend things in the global config.
This is needed because we need the ideal image to override the default loader I set for images.
See also #2956
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview