Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v1): external links #3011

Merged
merged 1 commit into from
Jun 30, 2020
Merged

docs(v1): external links #3011

merged 1 commit into from
Jun 30, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 29, 2020

Motivation

Undocumented v1 feature to add target=_blank to external links in navbar, see #2721

We should use this for github link + dogfooding

@slorber slorber requested a review from yangshun as a code owner June 29, 2020 13:07
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 29, 2020
@slorber slorber linked an issue Jun 29, 2020 that may be closed by this pull request
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit a4282c4

https://deploy-preview-3011--docusaurus-2.netlify.app

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 29, 2020
@yangshun yangshun merged commit 984e2d4 into master Jun 30, 2020
@yangshun yangshun removed the pr: documentation This PR works on the website or other text documents in the repo. label Jun 30, 2020
@yangshun yangshun deleted the slorber/v1-external-links branch June 30, 2020 01:06
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target blank in header link of siteconfig.js
4 participants