Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): fix broken links on versions page #3017

Merged
merged 2 commits into from
Jul 1, 2020
Merged

fix(v2): fix broken links on versions page #3017

merged 2 commits into from
Jul 1, 2020

Conversation

teikjun
Copy link
Contributor

@teikjun teikjun commented Jun 30, 2020 •
edited
Loading

Motivation

This PR fixes broken links on https://v2.docusaurus.io/versions/, and closes #3016.

It also fixes broken links to Remark and Rehype, as they have renamed their master branch.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Go to https://deploy-preview-3017--docusaurus-2.netlify.app/versions
  2. The 'Documentation' links should work
  3. Go to https://deploy-preview-3017--docusaurus-2.netlify.app/docs/markdown-features/#configuring-plugins
  4. The links at the following line should work
    image

@teikjun teikjun requested a review from yangshun as a code owner June 30, 2020 14:52
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 30, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 30, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit aee9739

https://deploy-preview-3017--docusaurus-2.netlify.app

@slorber slorber merged commit 086d1b7 into facebook:master Jul 1, 2020
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 1, 2020
@slorber
Copy link
Collaborator

slorber commented Jul 1, 2020

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun Awaiting requested review from yangshun

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links on versions page
4 participants
@teikjun @docusaurus-bot @slorber @facebook-github-bot