Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): showcase user Tasit #3034

Merged
merged 3 commits into from
Jul 9, 2020
Merged

docs(v2): showcase user Tasit #3034

merged 3 commits into from
Jul 9, 2020

Conversation

pcowgill
Copy link
Contributor

@pcowgill pcowgill commented Jul 8, 2020

Motivation

Adding another example of a Docusaurus v2 user to the showcase.

docs.tasit.io

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Please confirm that the showcase page renders properly with the new addition. Thanks!

Related PRs

n/a

@pcowgill pcowgill requested a review from yangshun as a code owner July 8, 2020 17:31
@facebook-github-bot
Copy link
Contributor

Hi @pcowgill!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 8, 2020

Deploy preview for docusaurus-2 ready!

Built with commit e3b9647

https://deploy-preview-3034--docusaurus-2.netlify.app

@pcowgill
Copy link
Contributor Author

pcowgill commented Jul 8, 2020

I'm not sure why the prettier check failed. This was the output:

#!/bin/bash -eo pipefail 
yarn prettier:diff 
yarn run v1.22.4
$ prettier --config .prettierrc --list-different "**/*.{js,ts}"
website/src/data/users.js
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Exited with code exit status 1 
CircleCI received exit code 1 

@pcowgill
Copy link
Contributor Author

pcowgill commented Jul 8, 2020

FYI I signed the CLA just now.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 8, 2020
@yangshun yangshun changed the title Add another v2 user to the showcase docs(v2): showcase user Tasit Jul 9, 2020
website/src/data/users.js Outdated Show resolved Hide resolved
@yangshun yangshun merged commit 233737e into facebook:master Jul 9, 2020
@yangshun
Copy link
Contributor

yangshun commented Jul 9, 2020

Thanks!

@pcowgill pcowgill deleted the feature/add-tasit-to-showcase branch July 9, 2020 00:44
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants