chore(v2): Adopt corejs 3 and only import at entry point #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 1e2fa3f |
|
Deploy preview for docusaurus-2 ready! Built with commit 877ce2d |
yangshun
approved these changes
Jul 14, 2020
|
usage vs entry probably has implications on the bundle size. With entry the initial bundle size is larger but page chunks may become smaller as polyfills are not inlined. Hard to know what is the best for the project ^^ I guess both options are acceptable Afaik we don't have bundle metrics over time, that could be interesting to setup some monitoring |
slorber
added
the
pr: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Core JS 2 is deprecated. It would be good if we don't stick with it forever.
I also changed to
useBuiltInsto beentryfor the purpose of Yarn pnp. If we useusage, babel will inject imports of core-js in literally every JS file. It will trick Yarn to believe that every single JS module depends on core-js, and therefore every package depends on core-js. Since core-js is not declared as a dependency for every package, it will trigger a lot of require errors. To patch that, you need to declare it on every package you use, like this, which doesn't scale.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)