fix(v2): classify link hrefs with protocol identifier as internal #3063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, only specific protocol links (http://, https://, tel: and mailto:) in the navbar and footer are treated as external - other protocols such as ssh://, sftp:// etc are treated as internal and get prepended with
baseUrl
which breaks the links.It would be nice to be able to have other protocols in links as well. My suggested solution is to let the
isInternalUrl
test check for any protocol identifier rather than specific ones.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Using the following navbar configuration in
docusaurus.config.js
Current behavior
The concerned navbar items are output as:
with
http://localhost:3000/
prepended to thehref
property on the last link.Behavior after the change
Navbar items are output as:
and all links are working as expected.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)