Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): async md image transformer + pathname protocol as an escape hatch #3087

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 21, 2020

Motivation

The new image transformer #3069 can work async. I gave it a try and converted it to async code so that it's non-blocking

Also added the pathname:// protocol as an escape hatch to fallback to old behavior, because next release could be risky without this, as we are now way more strict

@slorber slorber requested a review from yangshun as a code owner July 21, 2020 15:10
@slorber slorber added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Jul 21, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 21, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 21, 2020

Deploy preview for docusaurus-2 ready!

Built with commit b11d6bc

https://deploy-preview-3087--docusaurus-2.netlify.app

@slorber slorber merged commit 6730590 into master Jul 21, 2020
@yangshun yangshun deleted the slorber/transformImage-async branch July 26, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants