Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix recent baseurl issues #3093

Merged
merged 11 commits into from
Jul 22, 2020
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 22, 2020

Motivation

Some things don't currently work well with a baseUrl due to recent changes

This fixes the new issues + makes the Netlify CI build with baseurl

@slorber slorber requested review from lex111 and yangshun as code owners July 22, 2020 15:56
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 22, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 22, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 7cd7896

https://deploy-preview-3093--docusaurus-2.netlify.app

@yangshun
Copy link
Contributor

How do I see the preview with the baseUrl?

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jul 22, 2020
@slorber slorber merged commit 811c7ae into master Jul 22, 2020
@yangshun yangshun deleted the slorber/fix-baseurl-issues-a58 branch July 26, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants