Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add validation escape hatch #3134

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 27, 2020

Motivation

Validation is a new feature, and it's easy to write wrong validation schemas, as we've seen in the recent release (#3120)

This introduces a secret escape hatch that we could give to users if the new validation system gives false positives and rejects a config that used to work.

It's not worth documenting this escape hatch for now because we don't want users to use it without reporting the bad validation logic in the first place.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

manual

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Jul 27, 2020
@slorber slorber requested a review from yangshun as a code owner July 27, 2020 16:29
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 27, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 failed.

Built with commit fdd1659

https://app.netlify.com/sites/docusaurus-2/deploys/5f1f00d36d2c550007c4d1b0

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit cf51d51

https://deploy-preview-3134--docusaurus-2.netlify.app

@slorber slorber merged commit ac757e9 into master Jul 28, 2020
@yangshun yangshun deleted the slorber/validation-escape-hatch branch August 26, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants