Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v1): showcase user Casbin #3326

Merged
merged 2 commits into from
Aug 23, 2020
Merged

docs(v1): showcase user Casbin #3326

merged 2 commits into from
Aug 23, 2020

Conversation

hsluoyz
Copy link
Contributor

@hsluoyz hsluoyz commented Aug 22, 2020

Motivation

Casbin has been using Docusaurus as the official site for 2 years: https://casbin.org/ . It's really great!

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No test needed.

Related PRs

None

@hsluoyz hsluoyz requested a review from yangshun as a code owner August 22, 2020 02:39
@facebook-github-bot
Copy link
Contributor

Hi @hsluoyz!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 22, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit 05afab8

https://deploy-preview-3326--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 22, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yangshun yangshun changed the title Add Casbin to users dovs(v1): showcase user Casbin Aug 22, 2020
yangshun
yangshun approved these changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adinaja
Copy link
Contributor

adinaja commented Aug 22, 2020

Hi,
Just noticed that the title / commit message starts with dovs(v1), I guess this should be docs(v1) so it follows the guidelines?

@yangshun yangshun changed the title dovs(v1): showcase user Casbin docs(v1): showcase user Casbin Aug 23, 2020
@yangshun
Copy link
Contributor

Yep it's a typo. Thanks for pointing out

@yangshun yangshun merged commit 661eac4 into facebook:master Aug 23, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hsluoyz @facebook-github-bot @docusaurus-bot @adinaja @yangshun @slorber