Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(v2): make blog posts unit test ordering determinate #3339

Merged
merged 1 commit into from
Aug 27, 2020
Merged

test(v2): make blog posts unit test ordering determinate #3339

merged 1 commit into from
Aug 27, 2020

Conversation

BogdanDor
Copy link
Contributor

Motivation

Problem in docusaurus-plugin-content-blog.
Result of test different on local machine from server because order of blog posts depends on birthday of file.
Also two blog posts have similar date. It can affect to order.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

If you clone repository before 2020-02-27, maybe you don't have error.
For reproduce, you need recreate file docusaurus-plugin-content-blog/src/tests/fixtures/website/blog/no date.md
and run
yarn test docusaurus-plugin-content-blog

@BogdanDor BogdanDor requested a review from yangshun as a code owner August 26, 2020 19:55
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit ead6805

https://deploy-preview-3339--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 26, 2020
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Aug 27, 2020
@slorber
Copy link
Collaborator

slorber commented Aug 27, 2020

thanks 👍

@slorber slorber merged commit 3ccca39 into facebook:master Aug 27, 2020
@slorber slorber changed the title test(v2): Make unit test is determinate test(v2): make blog posts unit test ordering determinate Aug 27, 2020
@BogdanDor BogdanDor deleted the make-unit-test-is-determinate branch August 27, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants