Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): pin exact dependency versions #3386

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 1, 2020

Motivation

Part of #3371

We should ensure that all docusaurus packages are used on the exact same version, otherwise we can encounter strange runtime errors. It's better to be strict there.

Also, the lerna publish command should use --exact otherwise lerna will keep adding ^ after publish

Have you read the [Contributing Guidelines on pull requests]

Yes

Test Plan

Publish

Related PRs

#3162 (comment)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 1, 2020
@slorber slorber added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. and removed CLA Signed Signed Facebook CLA labels Sep 1, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 1, 2020

Deploy preview for docusaurus-2 ready!

Built with commit b3d6b06

https://deploy-preview-3386--docusaurus-2.netlify.app

@slorber slorber merged commit ab3ebda into master Sep 2, 2020
@slorber slorber added the CLA Signed Signed Facebook CLA label Sep 2, 2020
@lex111 lex111 deleted the slorber/pin-exact-versions branch October 7, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants