Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an .md extension from Installation link #3398

Closed
wants to merge 1 commit into from

Conversation

maksnester
Copy link

Motivation

Shows an issue from #3380

Have you read the Contributing Guidelines on pull requests?

No.

Test Plan

I would expect that onBrokenLink will report that broken link during the build time because it leads to 404.

Alternatively, the link should not lead to 404 but lead to the Installation page.

@maksnester maksnester requested a review from yangshun as a code owner September 3, 2020 12:56
@facebook-github-bot
Copy link
Contributor

Hi @maksnester!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit a802d7a

https://deploy-preview-3398--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Sep 3, 2020

Thanks for the repro, definitively helped me understand :) will answer in the issue

@slorber slorber closed this Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants