fix(v2): fix theme-classic announcement bar closeable style #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simek
changed the title
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 8a58590 |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refs #3388
The theme-classic announcement bar CSS style in the media query has not been correctly updated in the mentioned above PR. This results in additional, unnecessary margin on some devices when
isCloseableproperty was set tofalse.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Local run of Docusuaurs V2 website.
Related PRs