fix(v2): Correctly resolve sw.js path on windows #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 563e2eb |
|
thanks @ashscodes , LGTM, will merge it, just fixed the icons to see if this solves my inability to test the deploy previews PWA install mode (think icon is required to make it work) |
|
Great. Sorry, I forgot it would probably need the preceding |
|
No problem :) thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies, messed up here (#3431 - first attempt at a PR on GitHub) and thought it was best to re-submit.
Motivation
To ensure that the service worker is correctly referenced on builds on Windows operating systems. I created an issue and described the problem more here - #3420
Added change to docusaurus.config.js as per @slorber's comment here
I don't think the posix path function in utils is going to strip the drive letter off the path if it was used, so the problem would persist because path.resolve() will always include it and the sw.js should always be relative to the root directory. The posix path function, at least to me, appear to be fixing directory separators.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested on Windows and MacOS.
yarn startRelated PRs
N/A