fix(v2): Fixes serve cli --port option #3531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The command
serve
was not equipped to handle the value of port beingnull
.Also there was a typing mismatch where
port
input from CLI (string
) was type-casted as anumber
.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
The expected behavior can be seen here.
Related PRs
Fixes issue #3505 .