refactor(v2): various fixes #3587
Conversation
lex111
added
the
pr: polish
website/static/manifest.json
Outdated
| @@ -4,7 +4,7 @@ | |||
| "theme_color": "#2196f3", | |||
| "background_color": "#424242", | |||
| "display": "standalone", | |||
| "scope": "", | |||
| "scope": "/", | |||
There was a problem hiding this comment.
Fixes this error:
Manifest: property 'scope' ignored. Start url should be within scope of scope URL.
There was a problem hiding this comment.
This also breaks the PWA installation on the preview ^^
https://deploy-preview-3587--docusaurus-2.netlify.app/classic/
As the scope is relative to manifest, I guess "" means "/classic/manifest.json".
Maybe "./" would work, as it would lead to "/classic/" ? worth trying
There was a problem hiding this comment.
Maybe "./" would work
Did this, can you confirm that it worked?
| module.exports = function (context, options) { | ||
| return { | ||
| name: 'custom-docusaurus-plugin', | ||
| // highlight-start |
There was a problem hiding this comment.
More flexible way to keep highlighted proper lines.
|
Deploy preview for docusaurus-2 ready! Built with commit ba97fbe |
|
LGTM, the PWA + button seems back
Let's merge and hope it does not break in production 🤪 but should be fine |
Motivation
Just some fixes.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)