Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v2): add taro to users #3589

Merged
merged 1 commit into from
Oct 15, 2020
Merged

docs(v2): add taro to users #3589

merged 1 commit into from
Oct 15, 2020

Conversation

honlyHuang
Copy link
Contributor

Motivation

Showcasing a open source project that uses docusaurus v2 for documentation

@facebook-github-bot
Copy link
Contributor

Hi @honlyHuang!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 05c6570

https://deploy-preview-3589--docusaurus-2.netlify.app

lex111
lex111 reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @honlyHuang, please sign the CLA, otherwise we unable to merge your PR.

@honlyHuang honlyHuang requested a review from lex111 October 15, 2020 09:11
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 15, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

lex111
lex111 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lex111 lex111 merged commit d23940c into facebook:master Oct 15, 2020
@lex111
Copy link
Contributor

lex111 commented Oct 15, 2020

@honlyHuang thanks! BTW you are using an outdated version of Docusaurus, we recommend that you upgrade to stable latest one.

@honlyHuang honlyHuang deleted the docs-taro-zone branch October 15, 2020 11:34
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 19, 2020
@honlyHuang
Copy link
Contributor Author

@honlyHuang thanks! BTW you are using an outdated version of Docusaurus, we recommend that you upgrade to stable latest one.

Thank you very much, we have upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 lex111 approved these changes

@slorber slorber Awaiting requested review from slorber

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@honlyHuang @facebook-github-bot @docusaurus-bot @lex111 @slorber