Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): make optional title for footer links column #3666

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Oct 31, 2020

Motivation

Since the footer link item can only consist of raw HTML code, it makes sense to remove the required title for a footer column.

For example, the Gulp.js website uses that feature to add a logo, but they can't update to the latest Docusaurus because the footer title is required to specify (more precisely, this is one reason why it is impossible to upgrade, see the comment for more details).

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Remove title from footer link item, and make sure that the site start without validation errors.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner October 31, 2020 12:46
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 31, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit a6cf0e0

https://deploy-preview-3666--docusaurus-2.netlify.app

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 31, 2020
@slorber
Copy link
Collaborator

slorber commented Oct 31, 2020

agree, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants