-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): dogfood Yarn with enableGlobalCache #3673
Conversation
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit a3e1a1e |
LGTM, seems to be passing. |
@slorber No, but this was to just check whether the issue is fixed. I'm not sure it's worth adding these configurations, as this covers less common use cases. Using |
Is it more likely to fail with this setting = true? Does it have any drawback? I'm in favor to dogfood advanced options in our own CI, to ensure it keeps working over time, even if it's kind of useless |
Yes, due to the limitation of PnP. This would've failed with Yarn<2.3.0.
I cannot think of any drawbacks for now, as CI currently doesn't use cache. However if the cache were to be added, extra configuration might be needed.
I'll mark this PR ready for review. Thank you! |
thanks, seems safe to merge :) |
Motivation
Test for #3324.
I'm not sure this is worth testing in the e2e test.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Check GitHub Actions pass.
Related PRs
N/A