feat(v2): Added the ability to specify GIT_PASS in deploy command (for CI purposes) #3694
Conversation
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit e84a733 |
|
Hi @smcelhinney! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
thanks, that looks fine can you add some documentation about it? |
Sure thing, done! Hope that's sufficient. I didn't add examples as it's an optional parameter, and didn't want to confuse users. |
…aster' of github.com:facebook/docusaurus
|
LGTM :) |
slorber
changed the title
Motivation
We use CI to automatically deploy changes to docs. The current
deploycommand requires interactive password entry when no credential helper is set.Also, tidied up some variable declarations for readability.
Have you read the Contributing Guidelines on pull requests?
I certainly have - I've contributed before.
Related PRs
None.