Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): normalize showcase preview images height #3696

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Nov 5, 2020

Motivation

Currently on the V2 showcase page website preview images height is not restricted in any way which in some cases results in stretching preview cards too much.

This PR add small CSS tweak to the card image wrapper so it won't exceed height of 175px. The height was chosen arbitrary based on the current available images in the showcase directory. Image still can have smaller height that decaled and it will not affect the presentation.

The changeset also includes a removal of unused hook from the showcase page file.

Before

Screenshot 2020-11-05 150913

After

Screenshot 2020-11-05 150931

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Changes has been tested on the Docusuaurs V2 website locally.

Related PRs

No.

@Simek Simek requested a review from slorber as a code owner November 5, 2020 14:17
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 5, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 50cd235

https://deploy-preview-3696--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Nov 5, 2020

I don't have good eyes, can't see any difference 😅 can you help me understand which card is affected exactly?

@Simek
Copy link
Contributor Author

Simek commented Nov 5, 2020

@slorber Tasit is the example which I want to highlight on the screenshot, but there are some slight height reduction to other previews too. 🙂

@slorber
Copy link
Collaborator

slorber commented Nov 5, 2020

thanks, make sense now :)

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 5, 2020
@slorber slorber merged commit 3ee700c into facebook:master Nov 5, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants