Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): codesandbox generated examples should use published init package #3760

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Nov 16, 2020

We can't use the local "init" script, otherwise we may end up with upcoming config options that are not supported by current version.

See related Codesandbox error I just had due to this too-early option:

image

CodeSandbox will use the latest published version so we must ensure that we generate a project compatible with that version.

For this reason it's preferable to update the code sandbox examples just after a release (instead of before, like I initially thought)

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Nov 16, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 16, 2020
@slorber
Copy link
Collaborator Author

slorber commented Nov 16, 2020

@sammychinedu2ky had to change the behavior back finally 😅

@netlify
Copy link

netlify bot commented Nov 16, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 7a3da54

https://deploy-preview-3760--docusaurus-2.netlify.app

@github-actions
Copy link

Size Change: +22 B (0%)

Total Size: 152 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.84 kB 0 B
website/build/main.********.js 108 kB +22 B (0%)
website/build/styles.********.css 17.4 kB 0 B

compressed-size-action

@slorber slorber merged commit f26d478 into master Nov 16, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
slorber added a commit that referenced this pull request Jul 22, 2021
…kage (#3760)

* Fix codesandbox generated examples to use published init script instead of local one

* Fix codesandbox generated examples to use published init script instead of local one
@slorber slorber deleted the slorber/fix-codesandbox-templates branch August 17, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants