Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ConfigCat to showcase #3762

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Adding ConfigCat to showcase #3762

merged 2 commits into from
Nov 16, 2020

Conversation

sigewuzhere
Copy link
Contributor

Motivation

Upgraded from Docusaurus v1 to v2. So updated the v2 showcase as well.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Just checked the showcase page.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot
Copy link
Contributor

Hi @sigewuzhere!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Nov 16, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit ade9785

https://deploy-preview-3762--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 16, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 merged commit c69ea51 into facebook:master Nov 16, 2020
@lex111
Copy link
Contributor

lex111 commented Nov 16, 2020

@sigewuzhere thanks! I've changed URL website to docs path to better demonstrate the part of the site that uses Docusaurus.

@sigewuzhere
Copy link
Contributor Author

@lex111 Awesome! Thanks! 😸

@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
@lex111 lex111 added documentation The issue is related to the documentation of Docusaurus pr: documentation This PR works on the website or other text documents in the repo. and removed documentation The issue is related to the documentation of Docusaurus labels Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants