chore(v2): upgrade ESLint deps #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
commented
Nov 17, 2020
| @@ -114,6 +116,9 @@ module.exports = { | |||
| 'no-empty': WARNING, | |||
| 'no-prototype-builtins': WARNING, | |||
| 'no-case-declarations': WARNING, | |||
| 'no-undef': OFF, | |||
There was a problem hiding this comment.
Disabled this 'no-undef' rule as this causes a bunch of errors and to prevent double parsing in TS according to the recommendation from the issue typescript-eslint/typescript-eslint#2508
|
Deploy preview for docusaurus-2 ready! Built with commit e2bf1a9 |
|
Size Change: -18 B (0%) Total Size: 152 kB ℹ️ View Unchanged
|
slorber
reviewed
Nov 18, 2020
| allPluginDatas: Record<string, GlobalPluginData>, | ||
| pathname: string, | ||
| options?: GetActivePluginOptions, | ||
| ): ActivePlugin | undefined; |
There was a problem hiding this comment.
wonder why this is removed?
https://mariusschulz.com/blog/function-overloads-in-typescript#version-4-function-overloads
this is TS function overload to have more precise typing when some options are used (ie different return type). Does it cause any problem with ESLint?
There was a problem hiding this comment.
Ah, my bad, fixed it.
slorber
added
the
pr: maintenance
lex111
force-pushed
the
lex111/upd-eslint
branch
from
1321f1a
to
e2bf1a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trying to update packages related ESLint. There are some changes to the rules to make the checks run successfully, but overall nothing special.
Several npm warnings have been fixed along with this update:
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Deploy logs.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)