-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(v2): test swizzle on CI using v2 website #3840
Conversation
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 89b958e |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 08b1a82 |
Thanks, that's a good test idea 👍 We should probably ensure the test pass before merging 😅 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3840--docusaurus-2.netlify.app/classic/ |
Size Change: +15 B (0%) Total Size: 158 kB ℹ️ View Unchanged
|
9ad6395
to
3d63a1a
Compare
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
[V1] Deploy preview failure Built without sensitive environment variables with commit 08b1a82 https://app.netlify.com/sites/docusaurus-1/deploys/602bf03a5e52410007c2ab5c |
…ci-test-swizzle-on-v2
FYI: From the day when #3854 has been merged (Dec 01, 2020), running all the commands locally, in same order as in workflow results in successful build. The server compilation seems to fail only on the CI. I have tried many ideas to fix this, all of them failed. To be honest, I don't want to waste any minute more on this problem, @slorber can you step in? |
Motivation
#3830 - as reported, there is an issue with swizzled component form
theme-classic
right now.To prevent new swizzling errors from slipping into the release I have decided to add the swizzle test of most of
theme-classic
,theme-search-algolia
andtheme-live-codeblock
components to the CI pipeline. Test is based on the Docusuaurs V2 website and helper scripts starting withswizzle:v2
have been added to the mainpackage.json
.The list of components is subjective, feel free to change or update it 🙂
Currently the test step will fail for:
DocPage
andDocSidebar
components due to the same error as reported in the mentioned issueAfter fixing those problem the step run should be successful.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Manual command run and test builds on local. After publish
Related PRs
No.