chore(v2): fix several lint warnings, add missing types, cleanup #3844
Conversation
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit e98959f |
| @@ -18,21 +18,22 @@ const { | |||
| } = getFileLoaderUtils(); | |||
|
|
|||
| const createJSX = (node, pathUrl) => { | |||
| node.type = 'jsx'; | |||
| node.value = `<img ${node.alt ? `alt={"${escapeHtml(node.alt)}"} ` : ''}${ | |||
| const jsxNode = node; | |||
There was a problem hiding this comment.
why not rename the fn param directly?
There was a problem hiding this comment.
no-param-reassign rule - https://eslint.org/docs/rules/no-param-reassign
| ? sameProperties.filter((p) => !p.hasOwnProperty('important')) | ||
| ? sameProperties.filter( | ||
| (p) => !Object.prototype.hasOwnProperty.call(p, 'important'), | ||
| ) |
There was a problem hiding this comment.
that feels a bit verbose, wonder if we shouldn't just disable this eslint rule instead?
There was a problem hiding this comment.
I think it's fair to disable it, as much as leaving it on. The side effects or DDoS issues mentioned on the rule page seems not be related to the way those methods are used in the Docusuaurs code, but in the other hand I think that the slightly more verbose syntax won't hurt anyone, and there are only a few usages of hasOwnProperty in the whole codebase.
| priority: 0.5, | ||
| trailingSlash: false, | ||
| }; | ||
|
|
||
| export const PluginOptionSchema = Joi.object({ | ||
| cacheTime: Joi.number().positive().default(DEFAULT_OPTIONS.cacheTime), | ||
| changefreq: Joi.string() | ||
| .valid('always', 'hourly', 'daily', 'weekly', 'monthly', 'yearly', 'never') | ||
| .valid(...Object.values(EnumChangefreq)) |
There was a problem hiding this comment.
not very fan of enums (non-std js), and not alone
https://fettblog.eu/tidy-typescript-avoid-enums/
https://www.techatbloomberg.com/blog/10-insights-adopting-typescript-at-scale/
I think we'd rather avoid using them when possible, even if the underlying lib does use them
There was a problem hiding this comment.
Yeah, I'm also not a big fan of Enums, but the String variety isn't that bad as for example, heterogeneous or ambient enums.
Of course I can also change back the types. Would you like to revert EnumChangefreq usage completely or only the Enum values spread?
There was a problem hiding this comment.
let's keep it, just hope libs will stop exporting enums in the future :)
slorber
added
the
pr: maintenance
Motivation
This is cleanup PR which includes the following changes:
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Build & run of Docusaurs 2 website locally.
Related PRs
No.