Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix DocSearch keyboard navigator #3853

Merged
merged 5 commits into from
Dec 1, 2020

Conversation

francoischalifour
Copy link
Contributor

Motivation

This fixes the keyboard navigation integration with Docusaurus following breaking changes in the Autocomplete API (which is an underlying library of DocSearch).

You'll now be able to hit Enter to be redirected to the link, as you were before.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

N/A.

Related PRs

@netlify
Copy link

netlify bot commented Dec 1, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 4a1ce2f

https://deploy-preview-3853--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 1, 2020

Size Change: 0 B

Total Size: 157 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.86 kB 0 B
website/build/main.********.js 113 kB 0 B
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@github-actions
Copy link

github-actions bot commented Dec 1, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 75
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3853--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 1, 2020
@slorber
Copy link
Collaborator

slorber commented Dec 1, 2020

thanks 👍

@slorber slorber merged commit 915f949 into facebook:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants