docs(v2): typo #3856
docs(v2): typo #3856
Conversation
|
Hi @borool! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: bdab419 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fd2410ded60ea000762dff1 😎 Browse the preview: https://deploy-preview-3856--docusaurus-2.netlify.app |
slorber
added
the
pr: documentation
|
LGTM thanks 👍 |
|
Size Change: +22 B (0%) Total Size: 157 kB ℹ️ View Unchanged
|
|
will merge soon, but please sign the CLA (mandatory) |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3856--docusaurus-2.netlify.app/classic/ |
|
@borool can you sign the CLA please? otherwise I can't merge. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Hi Sébastien,
Done, sorry for the delay
пн, 7 дек. 2020 г. в 18:12, Sébastien Lorber <notifications@github.com>:
… @borool <https://github.com/borool> can you sign the CLA please?
otherwise I can't merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3856 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMSF4WSKBB3CPRFZX5FBMA3STT5GDANCNFSM4UJFOM5Q>
.
--
Best regards,
Oleksandr Borozenets
|
|
thanks will merge when CI pass |
That was written 2 times, I removed one "that"
Motivation
(Write your motivation here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)