Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing v1 generated files to ignores #3872

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Dec 3, 2020

Motivation

@slorber reported that after latest changes to ignores two generated files from v1 build are marked as unversioned. This PR fix that issue by adding the files to ignores.

Earlier they were part of removed .gitignore from v1 package.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

V1 build locally and run of git ls-files . --exclude-standard --others, yarn prettier and yarn lint.

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 3, 2020
@netlify
Copy link

netlify bot commented Dec 3, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 62e0c35

https://deploy-preview-3872--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 3, 2020

Size Change: 0 B

Total Size: 157 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.84 kB 0 B
website/build/main.********.js 113 kB 0 B
website/build/styles.********.css 17.5 kB 0 B

compressed-size-action

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 3, 2020
@slorber slorber merged commit 9ad02ca into facebook:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants