💅 hover - selected effect for the doc links in the sidebar

[albinotonnina]

Motivation

I would add some basic transitions for the rollover and the active state of a doc in the sidebar.

Before

After

Test Plan

No tests 😳

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[neilsutcliffe]

Why does it go to the left rather than the right?

Otherwise looks good

[albinotonnina]

@neilsutcliffe to mimic a sort of magnifying effect on hover, looked better to me :)

[JoelMarcey]

@albinotonnina Thank you for this pull request.

1. Will you please sign the CLA so that we can review and possibly merge it? https://code.facebook.com/cla

2. I wonder if this would be best enabled by a flag in siteConfig.js? You can turn off or on those animations. I need to think about that.

[albinotonnina]

Hi @JoelMarcey, I did sign the CLA yesterday :) Since you mention the config file, I would then go a step further in a future PR and implement some more transitions, what do you think? I’d like to share them with you anyway

_{Sent with GitHawk}

[neilsutcliffe]

@albinotonnina

If you fancy being super ambitious, do you want to be the creator/contributor to the very first theme for Docusaurus?

There is an issue #77, which is more than this pull request is at the moment, but there is no point adding custom theme support if we have no themes :)

I've been thinking of adding theming support, and have a few ideas of how it would work. What would make this a theme is.

• A cool dinosuar related name
• Custom colours (overridden by any in the config)
• Custom animations (where you feel they are needed)
• A cohesive design vision

It would be a big project, but would have to come after my refactor is finalized as well.

[albinotonnina]

That's what I would love to do @neilsutcliffe. I found Docusaurus a little restrictive at the moment in terms of theming/style authoring. Superb in terms of intentions though.
Consider me onboard, I will now quantify/qualify the effort and come back to you with proposals.

Would you also be open for a chat somewhere, to share some initial opinions?
Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[JoelMarcey]

@albinotonnina Hi. I am getting back to reviewing some pull requests now. Sorry for the delay.

Btw, if you want to join our Discord for Docusuarus chat, we are at https://discord.gg/docusaurus.

You and @neilsutcliffe can head into the #docusaurus-dev channel to discuss theming.

[yangshun]

@albinotonnina They look great, but this is probably not something that all Docusaurus users would want. It would be preferable if users had the choice to opt-in this behavior instead. Alternatively, users can also add this behavior via overriding the CSS. As discussed in the thread, this would be better as a theme/plugin which you have opened in #422.

Closing this for now so that we can shift the discussion there.