-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v1): Docker: remind the user to use the --host flag #4048
Conversation
Hi @tomsfernandez! Thank you for your pull request and welcome to our community. Action requiredTo get this pull-request merged, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. ProcessPlease sign the CLA at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA signed, I will tag this Pull-Request as ready to merge (it may take some time). If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
… flag Currently this part of the docs doesn't remind the user to use the --host flag. If the user doesn't use it, then the website will not be accessible outside of the docker container. This is what the user ultimately wants, to avoid using node and ruby and develop/productivize his website in a container.
2371c12
to
c954716
Compare
❌ [V1] Deploy preview failure 🔨 Explore the source changes: 2371c12 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-1/deploys/60006f7634eb8c00076a2b1c |
❌ [V1] Deploy preview failure 🔨 Explore the source changes: 2b20b6d 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-1/deploys/6001a885ac69d60008a90d35 |
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: 2371c12 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/60006f76a53fae00078eaa15 😎 Browse the preview: https://deploy-preview-4048--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4048--docusaurus-2.netlify.app/classic/ |
Size Change: +1 B (0%) Total Size: 26.8 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
Please sign the CLA so that we can merge the doc (the bot may detect it with some latency if you already did)
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: 2b20b6d 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/6001a8845e8dc60007d68bf4 😎 Browse the preview: https://deploy-preview-4048--docusaurus-2.netlify.app |
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
this should be good enough thanks |
Currently this part of the docs doesn't remind the user to use the --host flag. If the user doesn't use it, then the website will not be accessible outside of the docker container. This is what the user ultimately wants, to avoid using node and ruby and develop/productivize his website in a container.
Motivation
A clarification in the documentation is missing..
Have you read the Contributing Guidelines on pull requests?
Yes
Related PRs
Related issue: #4042