Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix navigation from homepage #4136

Merged
merged 1 commit into from
Jan 31, 2021
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jan 31, 2021

Motivation

Hotfix.

There was an error in #4125, as a result of which when we try to click on any internal link from the homepage, we get a blank page with errors in the console:

image

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner January 31, 2021 21:20
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 31, 2021
@netlify
Copy link

netlify bot commented Jan 31, 2021

[V1] Deploy preview success

Built with commit 8b0190a

https://deploy-preview-4136--docusaurus-1.netlify.app

@github-actions
Copy link

Size Change: -4 B (0%)

Total Size: 28.9 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.8 kB -3 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.92 kB -1 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Jan 31, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 8b0190a

https://deploy-preview-4136--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 83
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4136--docusaurus-2.netlify.app/classic/

@lex111 lex111 merged commit 39edfe3 into master Jan 31, 2021
@lex111 lex111 deleted the lex111/fix-banner-issue branch January 31, 2021 21:29
@slorber
Copy link
Collaborator

slorber commented Feb 1, 2021

thanks for fixing my mistake!

will try to find another way to do this

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 1, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants