Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): improve bad static assets doc + remove some useless useBaseUrl usage #4158

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Feb 2, 2021

Motivation

It's not useful to use useBaseUrl() in many places anymore (links, markdown images/links...) but the doc does not really reflect that.

This refreshes a bit the doc

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 2, 2021
@slorber slorber requested a review from lex111 as a code owner February 2, 2021 16:57
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 2, 2021
@netlify
Copy link

netlify bot commented Feb 2, 2021

[V1] Deploy preview success

Built with commit f10a8aa

https://deploy-preview-4158--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Feb 2, 2021

Deploy preview for docusaurus-2 ready!

Built with commit f10a8aa

https://deploy-preview-4158--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 2, 2021

Size Change: +13 B (0%)

Total Size: 508 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.7 kB 0 B
website/build/assets/js/1.********.js 68.5 kB 0 B
website/build/assets/js/11047cb5.********.js 3.76 kB 0 B
website/build/assets/js/11c63e03.********.js 170 B 0 B
website/build/assets/js/13019788.********.js 17.9 kB 0 B
website/build/assets/js/1346ae2b.********.js 3.87 kB 0 B
website/build/assets/js/13746fbc.********.js 3.44 kB 0 B
website/build/assets/js/140d3c4a.********.js 2.12 kB 0 B
website/build/assets/js/150b5325.********.js 5.39 kB 0 B
website/build/assets/js/154499b4.********.js 17.7 kB 0 B
website/build/assets/js/154cdb70.********.js 810 B 0 B
website/build/assets/js/17896441.********.js 5.92 kB 0 B
website/build/assets/js/18b93cb3.********.js 16.1 kB 0 B
website/build/assets/js/19ad9942.********.js 5.53 kB 0 B
website/build/assets/js/1a20bc57.********.js 5.27 kB 0 B
website/build/assets/js/1b5a23eb.********.js 3.04 kB 0 B
website/build/assets/js/1be78505.********.js 19.9 kB 0 B
website/build/assets/js/1c54c543.********.js 3.13 kB 0 B
website/build/assets/js/1dec8ae8.********.js 6.62 kB 0 B
website/build/assets/js/1eb3b288.********.js 1.85 kB 0 B
website/build/assets/js/1f391b9e.********.js 17.9 kB 0 B
website/build/assets/js/3.********.js 33.2 kB 0 B
website/build/assets/js/306a8c6c.********.js 295 B 0 B
website/build/assets/js/33a7e844.********.js 1.95 kB 0 B
website/build/assets/js/36f56357.********.js 1.96 kB 0 B
website/build/assets/js/37b746a6.********.js 6.39 kB 0 B
website/build/assets/js/38484a6e.********.js 4.4 kB 0 B
website/build/assets/js/38f00f86.********.js 172 B 0 B
website/build/assets/js/3a2bb492.********.js 205 B 0 B
website/build/assets/js/3b8c55ea.********.js 5.93 kB 0 B
website/build/assets/js/3c03c7ff.********.js 14.8 kB 0 B
website/build/assets/js/3c307864.********.js 13.8 kB 0 B
website/build/assets/js/3dc50dc3.********.js 6.43 kB 0 B
website/build/assets/js/3efe9127.********.js 3.29 kB 0 B
website/build/assets/js/3f4319ab.********.js 13.8 kB 0 B
website/build/assets/js/3fce4e4a.********.js 17.3 kB 0 B
website/build/assets/js/3fe38f54.********.js 18.6 kB 0 B
website/build/assets/js/main.********.js 109 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB -1 B (0%)

compressed-size-action

@github-actions
Copy link

github-actions bot commented Feb 2, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4158--docusaurus-2.netlify.app/classic/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants