-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Hashnode support site to showcase #4171
Conversation
Hi @iamshadmirza! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
[V1] Deploy preview failure Built without sensitive environment variables with commit 4897b47 https://app.netlify.com/sites/docusaurus-1/deploys/60213001d17cf500072b3c90 |
Size Change: -39 B (0%) Total Size: 156 kB ℹ️ View Unchanged
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 4897b47 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4171--docusaurus-2.netlify.app/classic/ |
thanks for choosing docusaurus 👍 just waiting for the CLA signature process to complete before being able to merge |
@iamshadmirza can you please sign the FB CLA? Unfortunately, I'm unable to merge this PR without it |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Hey @slorber, the CLA is signed. You can merge the PR now. Sorry for the delay. |
@iamshadmirza thanks! |
Motivation
We built Hashnode support site using docusaurus and want to showcase that on the
/showcase
pageHave you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I updated the files inside
website/src/data/users
and tested them by runningyarn start
Related PRs
None
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)