Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): localize 404 page with Netlify + docs #4178

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Feb 4, 2021

Motivation

Hint user to localize his 404 pages, as it's not done by default with jamstack hosts

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 4, 2021
@slorber slorber requested a review from lex111 as a code owner February 4, 2021 18:20
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 4, 2021
@netlify
Copy link

netlify bot commented Feb 4, 2021

[V1] Deploy preview success

Built with commit 8fdf2e9

https://deploy-preview-4178--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Feb 4, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 8fdf2e9

https://deploy-preview-4178--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4178--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

Size Change: +15 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 109 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.94 kB +1 B (0%)

compressed-size-action

@slorber slorber merged commit e3ae349 into master Feb 4, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/404-redirects branch August 17, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants