fix(v2): prepend docsearch modal to body element #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview success Built with commit 8fde69e |
|
Deploy preview for docusaurus-2 ready! Built with commit 8fde69e |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4188--docusaurus-2.netlify.app/classic/ |
|
Size Change: 0 B Total Size: 156 kB ℹ️ View Unchanged
|
|
Thanks @lex111 , seems to work and good enough for now Ping @Shipow @francoischalifour , any idea what's the cause of this safari scroll bug on modal close when we add Algolia modal to body? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Should fix #4088.
For some unknown reason, on Safari (actual at least for 12.1, 13.1, 14 versions, tested with BrowserStack) after closing docsearch modal, current page automatically scrolls to the bottom. This is a very strange bug, specific only to Safari, and after all my unsuccessful efforts I could not determine the reason for this. However, I found out that where docsearch was added does really matter -- if it is added as the first body element then the scrolling issue is solved.
Until we figure out why this is happening, I think we can use this fix.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Check it out preview site on Safari.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)