Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Added Console Table Documentation Site to showcase #4207

Merged
merged 1 commit into from
Feb 10, 2021
Merged

docs(v2): Added Console Table Documentation Site to showcase #4207

merged 1 commit into from
Feb 10, 2021

Conversation

ayonious
Copy link
Contributor

@ayonious ayonious commented Feb 9, 2021

Motivation

I created documentation site for a npm package Console Table Printer. I would like to showcase it in Docusaurus's Gallery.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Ran the project with yarn start and went to showcase tab.
Saw my project listed there.

Related PRs

None

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 9, 2021
@netlify
Copy link

netlify bot commented Feb 9, 2021

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

Size Change: +20 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 109 kB +15 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB +5 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.94 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 9, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 9061698

https://deploy-preview-4207--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4207--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 10, 2021
@slorber
Copy link
Collaborator

slorber commented Feb 10, 2021

thanks

@slorber slorber merged commit bdb7b9b into facebook:master Feb 10, 2021
title: 'Console Table',
description: 'Printing Pretty Tables on your console.',
preview: require('./showcase/console-table.png'),
website: 'https://console-table.netlify.app/',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @lex111 I think it's fine to accept Netlify domains like that, as long as it's a "production/stable" domain, without a random deployment number. It's a free hosting solution and not worst than accepting GH pages domains

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants