Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root URL was missing the baseURL portion. This is fine when a site is hosted on a custom URL such as docusaurus.io, because the generated URL will be valid (docusaurus.io/blog), but it breaks when the site is hosted on GitHub Pages (the React Native feed was using facebook.github.io/blog as the rootURL).
The current React Native feed looks like this (truncated):
Note that the id at the top is incorrect (https://facebook.github.io/blog), as well as the individual entry links (https://facebook.github.io/blog/2018/01/18/implementing-twitters-app-loading-animation-in-react-native.html).
After this change, the URLs should result in https://facebook.github.io/react-native/blog and https://facebook.github.io/react-native/blog/2018/01/18/implementing-twitters-app-loading-animation-in-react-native.html respectively.
Docusaurus's own feed is fine, because it's base URL is a plain / as it is hosted on its own domain.
Test Plan
Generate feed in
react-native-website
, confirm links have been fixed: