Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add requirements for sites being added to showcase #4210

Merged
merged 3 commits into from
Feb 10, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Feb 9, 2021

Motivation

I think these paragraphs will help tell people what sites we want to see in the showcase.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner February 9, 2021 17:52
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 9, 2021
@netlify
Copy link

netlify bot commented Feb 9, 2021

[V1] Deploy preview success

Built with commit 0e29fd3

https://deploy-preview-4210--docusaurus-1.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

Size Change: +87 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB +34 B (0%)
website/build/assets/js/main.********.js 109 kB +33 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB +11 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB +9 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 9, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 52997ba

https://deploy-preview-4210--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4210--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4210--docusaurus-2.netlify.app/classic/

@netlify
Copy link

netlify bot commented Feb 9, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 0e29fd3

https://deploy-preview-4210--docusaurus-2.netlify.app

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just updated some wordings to fix grammarly feedbacks + also set the bar lower for the "minimal customization" part which may be a bit unclear.

I'd like this page to have a lot of sites in the future, and will ask MLH fellows to build some kind of search engine with tags so that we can easily see Facebook sites, or sites with highly customized designs etc...

website/src/data/users.js Outdated Show resolved Hide resolved
@slorber slorber added pr: polish This PR adds a very minor behavior improvement that users will enjoy. pr: documentation This PR works on the website or other text documents in the repo. and removed pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Feb 10, 2021
@slorber slorber merged commit 7f6c4be into master Feb 10, 2021
@lex111 lex111 deleted the lex111-patch-2 branch February 19, 2021 18:20
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants