Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Removing wrong parenthesis on image variable #4226

Merged
merged 2 commits into from
Feb 16, 2021
Merged

docs(v2): Removing wrong parenthesis on image variable #4226

merged 2 commits into from
Feb 16, 2021

Conversation

juancarlosjr97
Copy link
Contributor

Removing a wrong parenthesis on image variable.

@netlify
Copy link

netlify bot commented Feb 15, 2021

@github-actions
Copy link

github-actions bot commented Feb 15, 2021

Size Change: +13 B (0%)

Total Size: 158 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 111 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB -2 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB +1 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 15, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 11db847

https://deploy-preview-4226--docusaurus-2.netlify.app

@@ -1072,7 +1072,7 @@ The ES imports syntax also works:

import myImageUrl from './assets/docusaurus-asset-example-banner.png';

<img src={myImageUrl)} alt="My image alternative text" />
<img src={myImageUrl} alt="My image alternative text" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Can you do that change in /website/docs/markdown-features.mdx too please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean by website/docs/guides/markdown-features/markdown-features-assets.mdx right @slorber ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the same file in the upstream version so that it's not lost on alpha 71 when we release it ;)

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4226--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 16, 2021
@slorber slorber changed the title Removing wrong parenthesis on image variable docs(v2): Removing wrong parenthesis on image variable Feb 16, 2021
@slorber slorber merged commit 2ff5d34 into facebook:master Feb 16, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants