-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): evaluate code in live editor on client only #4318
Conversation
[V1] Deploy preview success Built with commit d05c168 |
Deploy preview for docusaurus-2 ready! Built with commit d05c168 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4318--docusaurus-2.netlify.app/classic/ |
Size Change: 0 B Total Size: 532 kB ℹ️ View Unchanged
|
@slorber this PR does not solve the problem that we currently performing twice rendering (in order to define the proper Prism theme on the client-side during the initial rendering). For a more detailed I recommend you checkout these links:
Well, perhaps there is a better solution for this case? |
Perhaps there is a better solution, but this one seems to solve the problem without side effect for now so let's use that |
Yes, my previous comment was a challenge for the future to make you aware of why the |
thanks :) didn't know about these issues |
Motivation
Attempt to fix #2986 without much large changes.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Page with demo example - https://deploy-preview-4318--docusaurus-2.netlify.app/classic/examples/markdownPageExample#test
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)