Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): evaluate code in live editor on client only #4318

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Feb 28, 2021

Motivation

Attempt to fix #2986 without much large changes.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Page with demo example - https://deploy-preview-4318--docusaurus-2.netlify.app/classic/examples/markdownPageExample#test

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner February 28, 2021 22:56
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 28, 2021
@netlify
Copy link

netlify bot commented Feb 28, 2021

[V1] Deploy preview success

Built with commit d05c168

https://deploy-preview-4318--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Feb 28, 2021

Deploy preview for docusaurus-2 ready!

Built with commit d05c168

https://deploy-preview-4318--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4318--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: 0 B

Total Size: 532 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.1 kB 0 B
website/build/assets/js/main.********.js 359 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.4 kB 0 B

compressed-size-action

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Feb 28, 2021
@lex111
Copy link
Contributor Author

lex111 commented Feb 28, 2021

@slorber this PR does not solve the problem that we currently performing twice rendering (in order to define the proper Prism theme on the client-side during the initial rendering).

For a more detailed I recommend you checkout these links:

Well, perhaps there is a better solution for this case?

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 4, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 4, 2021

Perhaps there is a better solution, but this one seems to solve the problem without side effect for now so let's use that

@slorber slorber merged commit 0383dd1 into master Mar 4, 2021
@lex111
Copy link
Contributor Author

lex111 commented Mar 4, 2021

Yes, my previous comment was a challenge for the future to make you aware of why the isClient state was added, which causes a side effect as double rendering.

@slorber
Copy link
Collaborator

slorber commented Mar 4, 2021

thanks :) didn't know about these issues

@slorber slorber deleted the lex111/iss2986 branch August 17, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live editor render twice times on page first mount
3 participants