polish(v2): [theme-classic] slightly improve Japanese translation #4359
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 29a9298 https://app.netlify.com/sites/docusaurus-1/deploys/60463a50108dca0008795502 |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 29a9298 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4359--docusaurus-2.netlify.app/classic/ |
| @@ -43,13 +43,13 @@ | |||
| "theme.docs.sidebar.responsiveCloseButtonLabel": "メニューを閉じる", | |||
| "theme.docs.sidebar.responsiveOpenButtonLabel": "メニューを開く", | |||
| "theme.docs.versions.latestVersionLinkLabel": "最新バージョン", | |||
| "theme.docs.versions.latestVersionSuggestionLabel": "最新のドキュメントは{latestVersionLink} ({versionLabel}) を見てください。", | |||
| "theme.docs.versions.latestVersionSuggestionLabel": "最新のドキュメントは{latestVersionLink} ({versionLabel})を見てください。", | |||
There was a problem hiding this comment.
| "theme.docs.versions.latestVersionSuggestionLabel": "最新のドキュメントは{latestVersionLink} ({versionLabel})を見てください。", | |
| "theme.docs.versions.latestVersionSuggestionLabel": "最新のドキュメントは{latestVersionLink} ({versionLabel}) を見てください。", |
The space after the parentheses is required in Japanese as well.
There was a problem hiding this comment.
It's true :). Actually, I was originally adding a space between English letters and Japanese ones everywhere, which is a common typesetting style (the react website in Japanese follows this style for example), but since there's no standard rule for this, and the "no space between half-width and full-width characters (i.e. EN letters or half-width numbers/JP characters)" style is also very common in Japanese (I think we both agree on this), I ended up adopting the latter style and not adding spaces (and thus removed this space, which turns out to be unnecessary).
There was a problem hiding this comment.
Those labels are "default labels" that you can always override anyway
What does make sense for the majority of cases?
| "theme.lastUpdated.atDate": "{date}に", | ||
| "theme.lastUpdated.byUser": "{user}が", | ||
| "theme.lastUpdated.lastUpdatedAtBy": "{atDate}{byUser}最終更新", | ||
| "theme.tags.tagsListLabel": "タグ:", | ||
| "theme.tags.tagsListLabel": "タグ：", |
There was a problem hiding this comment.
| "theme.tags.tagsListLabel": "タグ：", | |
| "theme.tags.tagsListLabel": "タグ:", |
Do not need to change the ":" for appearance.
There was a problem hiding this comment.
does it have any special meaning in japanese?
There was a problem hiding this comment.
In the first place, there is nothing in Japanese that means ":". Generally this is just borrowed from English and has a similar meaning.
|
🤪 don't know how to review that. Can you agree on something with @ykzts or can you find someone that speaks Japanese to review this and decide what's best? |
We should remove the extra English period in line 48 ( |
slorber
added
the
pr: polish
|
thanks :) |
Motivation
Slightly improve the Japanese translation file by removing the extra English period in
theme.docs.versions.unreleasedVersionLabel(and with two other minor modifications).Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
N/A
Related PRs