-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): Showcase the pnpm docs #4386
Conversation
[V1] Deploy preview failure Built without sensitive environment variables with commit e691066 https://app.netlify.com/sites/docusaurus-1/deploys/604938a1f6e8b4000840f6a1 |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit d2746d5 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4386--docusaurus-2.netlify.app/classic/ |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit e691066 |
Thanks ! Cool to see i18n already used :) |
Yes, you should really bump the version to 2. It works as well as 1. |
great to know ;) thanks for the feedback |
Motivation
(Write your motivation here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)